[#273] Backfill genre and language for E2E storylines 34-42#553
[#273] Backfill genre and language for E2E storylines 34-42#553realproject7 merged 2 commits intomainfrom
Conversation
Map each storyline to the correct genre from lib/genres.ts and language from the E2E script metadata. Fixes "Uncategorized" display and broken language filter for Foundry-created storylines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Verified all genre values against lib/genres.ts GENRES list and all language values against LANGUAGES list — all match exactly (case-sensitive). Genre mappings are reasonable approximations where exact subgenres (Wuxia, Magical Realism, Slice of Life, etc.) aren't in the list. Migration is clean — simple UPDATE statements targeting IDs 34-42 as specified.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The migration does not match issue #551 yet. The updates are missing the ticketed v4b contract-address guard, and storyline 41 is backfilled to the wrong genre.
Findings
- [high] Issue #551’s required SQL scopes every
UPDATEto the v4b factory address0x9D2AE1E99D0A6300bfcCF41A82260374e38744Cf, but this migration updates rows bystoryline_idonly. If the same IDs exist on any other contract, this will overwrite unrelated rows.- File:
supabase/migrations/00026_backfill_e2e_genre_language.sql:9 - Suggestion: Add
AND lower(contract_address) = lower('0x9D2AE1E99D0A6300bfcCF41A82260374e38744Cf')to eachUPDATE, matching issue #551.
- File:
- [high] Storyline 41 is set to
Fantasy, but issue #551’s required mapping isOthers. As written, the migration will still leave that storyline with the wrong genre after deploy.- File:
supabase/migrations/00026_backfill_e2e_genre_language.sql:30 - Suggestion: Change storyline 41’s
genretoOthers.
- File:
Decision
Request changes until the migration matches the issue #551 SQL exactly.
Address T2a review: - Scope all UPDATEs to v4b factory (0x9D2AE1E9...) to prevent overwriting rows from other contracts - Change storyline 41 genre from 'Fantasy' to 'Others' per ticket Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The migration now matches the Batch 21 backfill scope: each storyline update is scoped to the v4b factory address, and storyline 41 uses the ticketed Others genre.
Findings
- None.
Decision
Approve. The remaining SQL is consistent with issue #551 and addresses the previously requested fixes.
2 participants
Summary
Fixes #273
Adds migration
00026_backfill_e2e_genre_language.sqlto set genre and language for the 9 E2E storylines (IDs 34-42) created via Foundry scripts. These had no genre (showing "Uncategorized") and defaulted to English regardless of actual language.Genre/language mapping derived from E2E script comments (
CreateStorylines.s.sol):All genre values match
lib/genres.tsGENRES exactly (case-sensitive). All language values match LANGUAGES exactly.Test plan
🤖 Generated with Claude Code